Fix consolidacion #103
Open
Fix consolidacion #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaitan
reviewed
May 31, 2021
| @@ -471,6 +471,10 @@ | |||
| # Ver csv_import.py | |||
| OPCIONES_CARGAS_TOTALES_COMPLETAS = True | |||
|
|
|||
| # Flag para decidir si usamos el mecanismo de trolling automático. | |||
| # Independientemente de este flag, se pueden marcar trolls desde el admin. | |||
| CON_ANTITROLLING = True | |||
There was a problem hiding this comment.
en vez de hacer esto, no es posible simplemente comentar "antitrolling" de las INSTALLED_APPS ?
There was a problem hiding this comment.
Pero entonces habría que sacar todos los imports de antitrolling o hacerlos condicionales a que esté la aplicación. ¿Cuál es la contra de esto?
mgaitan
reviewed
May 31, 2021
Comment on lines
+310
to
+311
| con_error |= (ids_a_procesar & identificaciones_ids) | ||
| ids_a_procesar -= identificaciones_ids |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Este PR agrega un flag que controla si se ejecuta automáticamente el calculador de trolling. Los tests asumen que sí se hace el anti-trolling.
Además simplificamos un poco el código de consolidación.
Closes escrutinio-social-peru#2