Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update code after running lintr #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update code after running lintr #4

wants to merge 2 commits into from

Conversation

hallvaaw
Copy link
Contributor

Ran lintr to lint the R-code and increase readability by fixing spaces after commas, trailing whitespaces etc.

ankushs0128
ankushs0128 requested changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@ankushs0128 ankushs0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trajectory_name<-"LymphoidU" is missing !
Did you run ShinyArchR.UiO running after lintr?

@hallvaaw
Copy link
Contributor Author

I missed trajectory_name<-"LymphoidU" during the lint so it still has the old syntax, but it is still there in global.R. I have not been able to run ShinyArchR.UiO due to some installation problems with Rstudio before the lint. Can you try to run it to see if it still works after linting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankushs0128 ankushs0128 ankushs0128 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hallvaaw @ankushs0128