Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutputChunked don't need to do twice super.flush() #838

Closed
jackjoesh opened this issue Jun 26, 2021 · 2 comments · Fixed by #839
Closed

OutputChunked don't need to do twice super.flush() #838

jackjoesh opened this issue Jun 26, 2021 · 2 comments · Fixed by #839

Comments

@jackjoesh
Copy link
Contributor

Describe the bug

I think the OutputChunked don't need to do twice super.flush(), it may waste cpu usage

image

can we modify the code, as following:

image

Wait for help, thank you!

@theigl
Copy link
Collaborator

theigl commented Jun 29, 2021

@jackjoesh: Thanks for your suggestion. Please provide a PR with your suggested changes so we can discuss it further and can see what issues it might cause.

@jackjoesh
Copy link
Contributor Author

@jackjoesh: Thanks for your suggestion. Please provide a PR with your suggested changes so we can discuss it further and can see what issues it might cause.

Thank you, here is my pr: #839
Please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants