AccessClassLoader.accessClassLoaders list is never added to

[ghost]

From serverpe...@gmail.com on June 12, 2012 16:24:29

Current version of AccessClassLoader.get(Class):

static AccessClassLoader get (Class type) {
    ClassLoader parent = type.getClassLoader();
    for (int i = 0, n = accessClassLoaders.size(); i < n; i++) {
        AccessClassLoader accessClassLoader = accessClassLoaders.get(i);
        if (accessClassLoader.getParent() == parent) return accessClassLoader;
    }
    return new AccessClassLoader(parent);
}

I think it shoud be something like this (and synchronized or double-checked with volatile):

static synchronized AccessClassLoader get (Class type) {
    ClassLoader parent = type.getClassLoader();
    for (int i = 0, n = accessClassLoaders.size(); i < n; i++) {
        AccessClassLoader accessClassLoader = accessClassLoaders.get(i);
        if (accessClassLoader.getParent() == parent) return accessClassLoader;
    }
    AccessClassLoader newClassLoader = new AccessClassLoader(parent);
    accessClassLoaders.add(newClassLoader);
    return newClassLoader;
}

Regards

Original issue: http://code.google.com/p/reflectasm/issues/detail?id=6

[ghost]

From nathan.s...@gmail.com on June 13, 2012 04:07:30

Good find, thanks!

Status: Fixed

[ghost]

From nathan.s...@gmail.com on June 13, 2012 04:07:34

This issue was closed by revision r31.