Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash parenting attachments from one skeleton to bones in another skeleton #238

Closed
erikari opened this issue Aug 8, 2017 · 3 comments
Closed
Assignees

Comments

@erikari
Copy link
Collaborator

erikari commented Aug 8, 2017

http://esotericsoftware.com/forum/Crash-every-time-picture-is-parented-to-bone-9132?p=41377

@NathanSweet NathanSweet changed the title Spine crashes if you try to parent the attachments from one skeleton to the bones in another skeleton Crash parenting attachments from one skeleton to bones in another skeleton Sep 10, 2017
@NathanSweet
Copy link
Member

This issue has no repro steps. Also the reporting user included the wrong log which does not show the crash. We should push the user to both provide steps for how they cause the problem, and to provide the right crash logs.

@erikari You mentioned on the forum that we would show an alert instead of crashing, but this is not possible. A crash happens because the program gets in an unexpected state. Because it never expected to be in that state, it doesn't know if it can recover from or ignore whatever has occurred. To show an alert, we would need to understand what happened to put the program in a bad state, at which point we could just fix the problem rather than showing an alert. To understand what happened, we need repro steps.

I toyed around with the user's project and found repro steps that are most likely the same problem:

  1. Click an image on the Images node (not an attachment).
  2. Drag or use Set Parent to put the image in a different skeleton.
    Actual: Crash.
    Expected: Either allow or disallow the parent change.

@erikari
Copy link
Collaborator Author

erikari commented Sep 11, 2017

@NathanSweet got it. Bad me. Will make better reports in the future. Thanks for explaining (:

@NathanSweet
Copy link
Member

No worries. :)

Fixed in 3.6.40!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants