remove guessing of next auto_increment id #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting the `max() + 1` of the id column does not reliably return the next used auto_increment id. This PR adds an extra query in order to save the model, then update the model with the newly used ID. This will remove badly guessed IDs from deletions and race conditions of multiple concurrent saves
|
damn, PR sent to the wrong place. meant to send to sbarre/eloquent-versioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the
max() + 1of the id column does not reliably return the next used auto_increment id.This PR adds an extra query in order to save the model, then update the model with the newly used ID.
This will remove badly guessed IDs from deletions and race conditions of multiple concurrent saves
p.s. my first ever PR. I hope all is in order.
Feedback is appreciated :)