updated truffle to v5 and solidity to 0.5.3 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #9 |
|
I found the workaround how to force solidity-coverage to work with solidity >= 0.5 (did it the same way like OpenZeppelin). The drawback is that I was pushed to downgrade solidity from 0.5.3 to 0.5.0. |
tcichowicz
previously approved these changes
Feb 6, 2019
tcichowicz
reviewed
Jun 4, 2019
tcichowicz
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains upgrading truffle framework to v5 version and solidity language itself up to 0.5.3. Although no business changes were introduced to Gardener itself, many changes were needed to in order to make it worked with new major versions of language and framework. There is still not resolved problem with solidity coverage, which seems to not support solidity >= 0.5.0. Some more info on that problem here