Simplify the waveform reading code #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine the Android and non-Android implementations. Only difference now is the path to the waveform data. Remove arbitrarily-sized buffers and most C-style string handling function calls. Use native Qt string methods instead; this should improve memory safety.
|
Thanks! So much more compact now. |
EspoTek
added a commit
that referenced
this pull request
Nov 16, 2021
turboencabulator
added a commit
to turboencabulator/Labrador
that referenced
this pull request
Sep 21, 2022
Combine the Android and non-Android implementations. Only difference now is the path to the waveform data. Remove arbitrarily-sized buffers and most C-style string handling function calls. Use native Qt string methods instead; this should improve memory safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the Android and non-Android implementations. Only difference
now is the path to the waveform data.
Remove arbitrarily-sized buffers and most C-style string handling
function calls. Use native Qt string methods instead; this should
improve memory safety.