Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto Bench] Integrate push-based CDN to scripts of auto benchmarking on AWS #3135

Merged
merged 80 commits into from
Jun 20, 2024

Conversation

dailinsubjam
Copy link
Contributor

@dailinsubjam dailinsubjam commented May 9, 2024

Closes #2827 .
Sorry for such a large PR, part of it are changes on simple builder which covers #3210 @QuentinI Let me know if there's a way to separate it into another PR.

This PR:

  • Adds script of running benchmarks with push-based CDN
  • Adds a README on running benchmarks on AWS and a README on running examples locally with push cdn
  • Update and re-organize old scripts with gpu
  • Does some changes to benchmark output structure and input parameters
  • Covers the simple builder changes of [DRAFT] Builder only on DA nodes #3210 and Benchmarking adjustments #3324
  • Adds some benchmark results

This PR does not:

  • update the image tag. It's still ghcr.io/espressosystems/hotshot/validator-webserver:main-async-std for now. It seems the new tag will only be created when this runs on main. I will update the tag in the next PR after this one is merged and the image is tested successfully.

Key places to review:

Scripts in scripts/benchmark_scripts.

How to test this PR:

scripts/benchmarks_results/README.md

@dailinsubjam dailinsubjam requested a review from ss-es as a code owner May 9, 2024 01:31
@dailinsubjam dailinsubjam marked this pull request as ready for review June 7, 2024 22:01
crates/examples/infra/mod.rs Outdated Show resolved Hide resolved
crates/examples/infra/mod.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
crates/examples/combined/all.rs Outdated Show resolved Hide resolved
crates/examples/infra/mod.rs Outdated Show resolved Hide resolved
crates/examples/libp2p/all.rs Outdated Show resolved Hide resolved
@dailinsubjam dailinsubjam force-pushed the sishan/benchmark_push_cdn_from_main branch from 91aba4f to ef753e7 Compare June 14, 2024 19:30
@dailinsubjam dailinsubjam dismissed elliedavidson’s stale review June 20, 2024 21:00

comments are resolved

@dailinsubjam dailinsubjam merged commit 7e93c00 into main Jun 20, 2024
36 checks passed
@dailinsubjam dailinsubjam deleted the sishan/benchmark_push_cdn_from_main branch June 20, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Auto Benchmarks] - Integrate push-based CDN to scripts of auto benchmarking on AWS
5 participants