Allow genesis to time out #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr721
requested changes
May 22, 2024
ss-es
reviewed
May 22, 2024
Comment on lines
40
to
62
| /// A helper function to create a timeout task from a given `SystemContextHandle`. | ||
| fn timeout_task_from_handle<TYPES: NodeType, I: NodeImplementation<TYPES>>( | ||
| handle: &SystemContextHandle<TYPES, I>, | ||
| ) -> JoinHandle<()> { | ||
| // Clone the event stream that we send the timeout event to | ||
| let event_stream = handle.internal_event_stream.0.clone(); | ||
| let next_view_timeout = handle.hotshot.config.next_view_timeout; | ||
| let start_view = handle.hotshot.start_view; | ||
|
|
||
| // Spawn a task that will sleep for the next view timeout and then send a timeout event | ||
| // if not cancelled | ||
| async_spawn({ | ||
| async move { | ||
| async_sleep(Duration::from_millis(next_view_timeout)).await; | ||
| broadcast_event( | ||
| Arc::new(HotShotEvent::Timeout(start_view + 1)), | ||
| &event_stream, | ||
| ) | ||
| .await; | ||
| } | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
Nit: could this be in impl SystemContextHandle as e.g. startup_timeout_task?
There was a problem hiding this comment.
Sure, I thought about putting it there but didn't know if it was relevant to that part of the code
There was a problem hiding this comment.
I don't actually have a strong opinion -- if you think it shouldn't be there, I'm fine with it being a stand-alone function!
There was a problem hiding this comment.
@rob-maron lmk if you decide to do this, I can approve afterwards.
ss-es
previously approved these changes
May 22, 2024
|
I had to update it to wait for the Libp2p network to be ready first, since it was not fast enough for the first view |
jparr721
previously approved these changes
May 22, 2024
Comment on lines
40
to
62
| /// A helper function to create a timeout task from a given `SystemContextHandle`. | ||
| fn timeout_task_from_handle<TYPES: NodeType, I: NodeImplementation<TYPES>>( | ||
| handle: &SystemContextHandle<TYPES, I>, | ||
| ) -> JoinHandle<()> { | ||
| // Clone the event stream that we send the timeout event to | ||
| let event_stream = handle.internal_event_stream.0.clone(); | ||
| let next_view_timeout = handle.hotshot.config.next_view_timeout; | ||
| let start_view = handle.hotshot.start_view; | ||
|
|
||
| // Spawn a task that will sleep for the next view timeout and then send a timeout event | ||
| // if not cancelled | ||
| async_spawn({ | ||
| async move { | ||
| async_sleep(Duration::from_millis(next_view_timeout)).await; | ||
| broadcast_event( | ||
| Arc::new(HotShotEvent::Timeout(start_view + 1)), | ||
| &event_stream, | ||
| ) | ||
| .await; | ||
| } | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
@rob-maron lmk if you decide to do this, I can approve afterwards.
ss-es
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No linked issue.
During test deployments, we ran into a case where the genesis block would never time out. If we ever didn't see genesis for any reason (not enough nodes saw it from the CDN, builder has wrong commitment), the network would hang indefinitely.
This PR
Fixes that fragility by always requiring a timeout task to be present.
I tested it upstream on the sequencer and we can indeed time out view 0 now