Minor test fixes (again) #3317
Merged
Minor test fixes (again) #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr721
previously requested changes
Jun 17, 2024
bfish713
previously approved these changes
Jun 20, 2024
jparr721
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No linked issue.
This PR:
This is a second attempt at #3256, which was reverted. The tightening of the
num_failed_viewsparameter in various tests is retained, but the check that we fail no fewer thannum_failed_viewswas removed (since many tests do not reliably fail a specific number of views, this requires more work).A consistency check was also added, to validate that each leaf chain from each node's decide events is coherent, and that no two nodes disagree on a leaf for any given view.
This PR does not:
Key places to review: