[CATCHUP] Fetch Proposals in Dependecny Task #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr721
reviewed
Jun 19, 2024
| let sender = self.sender.clone(); | ||
| let consensus = Arc::clone(&self.consensus); | ||
| async_spawn(async move { | ||
| fetch_proposal(high_qc_view_number, sender, memberhsip, consensus).await |
There was a problem hiding this comment.
How come this is an async spawn instead of just calling? It looks like the method doesn't do anything long-running?
There was a problem hiding this comment.
The fetch could be potentially very slow (500ms) and this caller isn't expecting the result directly back, in the mean time we might get the ValidatedStateUpdated event we need before the request for proposal ever even finishes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3244
This PR:
fetch_proposalfunctionThis PR does not:
Key places to review: