Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set RUSTFLAGS for coverage #1370

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Only set RUSTFLAGS for coverage #1370

merged 1 commit into from
Apr 23, 2024

Conversation

sveitser
Copy link
Collaborator

@sveitser sveitser commented Apr 23, 2024 •
edited

Currently the coverage workflow is broken because we set RUSTFLAGS globally that only work with nightly.

@sveitser sveitser requested a review from tbro April 23, 2024 15:17
@sveitser
Copy link
Collaborator Author

CI run: https://github.com/EspressoSystems/espresso-sequencer/actions/runs/8802942220

@sveitser sveitser marked this pull request as ready for review April 23, 2024 16:00
@sveitser sveitser enabled auto-merge (squash) April 23, 2024 16:00
tbro
tbro approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@tbro tbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage passes so it should be good. I don't understand why only setting vars for coverage fixes coverage? Or were they being overridden for coverage since they were set globally?

@sveitser sveitser merged commit c0726f4 into main Apr 23, 2024
15 checks passed
@sveitser sveitser deleted the ma/fix-coverage-ci-ng branch April 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbro tbro tbro approved these changes

@nomaxg nomaxg Awaiting requested review from nomaxg nomaxg is a code owner

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sveitser @tbro