Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for open sourcing #1

Closed
18 tasks done
zhenfeizhang opened this issue Jan 10, 2022 · 3 comments
Closed
18 tasks done

Preparing for open sourcing #1

zhenfeizhang opened this issue Jan 10, 2022 · 3 comments
Assignees

Comments

@zhenfeizhang
Copy link
Contributor

zhenfeizhang commented Jan 10, 2022

Here are a list of todos; ESSENTIAL are the ones that need to be solved before we open up this repo:

  • logistics
    • [ESSENTIAL] choose a proper license: MIT
    • [ESSENTIAL] proper reading/writing permissions
    • create a channel for the community: telegram, discord, others? do it after open sourcing
    • create a PR template
  • documentation
    • [ESSENTIAL] update read me
    • update cargo doc
  • code
    • [ESSENTIAL] conduct one more code review and remove sensitive info
    • [ESSENTIAL] update other libraries to make sure nothing breaks
    • [ESSENTIAL] add Plonk benchmark
    • [ESSENTIAL] open source tagged-base64 repo
    • check testing coverage
    • update to latest dependencies expose apis under testing #12
    • check benchmark scripts
    • expose test API via feature test expose apis under testing #12
  • badges (low priority)
    • license
    • CI
    • crates.io (after code is published at crates.io)
    • test coverage <- require a dedicated CI service
@chancharles92
Copy link
Contributor

Should "update README" also be a "ESSENTIAL"? There are some paragraphs related to transaction generation/verification that need to be deleted.

@alxiong
Copy link
Contributor

alxiong commented Jan 15, 2022

  • auto enable direnv via .envrc, so that community can easily enter our nix-shell when cd into the directory with all dep installed and ready to run (add instruction to run direnv allow inside "Getting Started")
  • remove cargo husky and use nix's pre-commit hooks

@sveitser Can you help us submit a PR for ☝️ ?

@alxiong
Copy link
Contributor

alxiong commented Jan 20, 2022

@chancharles92 I think we should also highlight some advanced feature we had including proving key merging and batched proving in the README (with benchmark?) as well?

open-sourcing automation moved this from In progress to Done Feb 9, 2022
SuccinctPaul pushed a commit to SuccinctPaul/jellyfish that referenced this issue Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants