Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump icicle to v2.6.0 #595

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

chore: bump icicle to v2.6.0 #595

wants to merge 8 commits into from

Conversation

mrain
Copy link
Contributor

@mrain mrain commented May 29, 2024

no issue related.

This PR:

  • bump icicle deps to v2.6.0
    • HostOrDeviceSlice is now a trait. Occurrences are changed to concrete types now.
    • For Bn254 curve impl
      • commit_on_gpu now assume that the input scalars are in normal form instead of montgomery form.
      • now load_poly_to_gpu has one memory copy instead of free as before
      • these are because, icicle field impl now uses u32 limbs instead of u64 limbs as in arkworks.
  • add GPU stress test for memory leakage/fragmentation

This PR does not:

Key places to review:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added relevant changelog entries to the CHANGELOG.md of touched crates.
  • Re-reviewed Files changed in the GitHub PR explorer

@mrain mrain changed the title chore: bump icicle to v2.3.1 chore: bump icicle to v2.4.0 Jun 10, 2024
@alxiong
Copy link
Contributor

alxiong commented Jul 3, 2024

thanks @mrain for taking the initiative to upgrade our icicle dep! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants