-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zprice test vectors and benchmark code #71
Conversation
"Storing universal parameter to: {} ...", | ||
dest.to_str().unwrap() | ||
); | ||
store_data(&universal_param, dest); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we should also store a hash digest of the srs (which we will also put in the readme.md?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a minor comment on the srs digest for which I can try to obtain after running the instance.
Yes, @zhenfeizhang , we should produce sha256sum for all binary files and version controlled them. an example of this is: |
This PR includes: