Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Snark -> UniversalSNARK trait #80

Merged
merged 3 commits into from
Jul 19, 2022
Merged

update Snark -> UniversalSNARK trait #80

merged 3 commits into from
Jul 19, 2022

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Jul 18, 2022 •
edited

Description

Major changes include:

  • Remove 'a lifetime from CommitterKey for kzg therefore most of other related structs by introducing conversion from CommitterKey to ark_poly_commit::kzg10::Powers
  • Add back universal_setup and circuit-specific preprocess back to trait Snark
  • Rename trait Snark to trait UniversalSNARK

closes: #78

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@alxiong alxiong self-assigned this Jul 18, 2022
@alxiong alxiong changed the base branch from main to cap-rollup July 18, 2022 09:25
@alxiong
Copy link
Contributor Author

alxiong commented Jul 18, 2022

Q: do we want to consider switching to MarlinKZG10, seems much better APIs (avoiding unnecessary lifetimes to public structs, supporting batch opening API etc)?

cc @chancharles92, @zhenfeizhang WDYT?

zhenfeizhang
zhenfeizhang approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@zhenfeizhang zhenfeizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. a few minor comments

plonk/src/proof_system/mod.rs Show resolved Hide resolved
plonk/src/proof_system/structs.rs Outdated Show resolved Hide resolved
plonk/src/proof_system/snark.rs Outdated Show resolved Hide resolved
@alxiong alxiong mentioned this pull request Jul 18, 2022
Open
@alxiong alxiong merged commit 0a89b0b into cap-rollup Jul 19, 2022
@alxiong alxiong deleted the alex-refine-snark-trait branch July 19, 2022 14:45
@alxiong alxiong mentioned this pull request Jul 28, 2022
Merged
6 tasks
alxiong added a commit that referenced this pull request Jul 29, 2022
@alxiong
no_std compliance and refactor SNARK trait (#87)
d1637ad 
* update Snark -> UniversalSNARK trait (#80)

* update Snark -> UniversalSNARK trait

* enable CI on PR targetting cap-rollup branch

* address Zhenfei's comment

* Restoring no_std compliance (#85)

* restore no_std on jf-*

* remove HashMap and HashSet for no_std

* fix bench.rs, add Display to TaggedBlobError

* more no_std fix

* put rayon to feature=parallel

* use hashbrown for HashMap, update es-commons

* simplify rayon-accelerated code

* update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenfeizhang zhenfeizhang zhenfeizhang approved these changes

@chancharles92 chancharles92 Awaiting requested review from chancharles92

Assignees

@alxiong alxiong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API]: conform to standardized SNARK traits
2 participants
@alxiong @zhenfeizhang