Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync upstream 20240709 #143

Merged
merged 722 commits into from
Jul 13, 2024
Merged

Sync upstream 20240709 #143

merged 722 commits into from
Jul 13, 2024

Conversation

ImJeremyHe
Copy link

@ImJeremyHe ImJeremyHe commented Jul 9, 2024

This PR:

  • Sync
  • Remove the switch test since the escape hatch test is already integrated into e2e test

This PR does not:

add other features or fix other things

amsanghi and others added 30 commits June 12, 2024 16:58
This message will be seen by external users, so we should avoid
mentioning the data poster.
Initially, this package is able to prase the download URLs and wasm
root hash from a consensus release.
…reater-tip

Make sure fee > tip in validator wallet estimateGas
…ter_dangerous_config

[NIT-2593] Tests for AllowPostingFirstBatchWhenSequencerMessageCountMismatch
The bulk of this change is wiring the Wasm.RootPath through to the
right places to make sure that all of the machine locators are
initialized with the same root.
@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 9 committers have signed the CLA.

✅ ImJeremyHe
❌ Tristan-Wilson
❌ ganeshvanahalli
❌ magicxyyz
❌ tsahee
❌ PlasmaPower
❌ joshuacolvin0
❌ eljobe
❌ gligneul
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@zacshowa zacshowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Just one clarifying question that shouldn't stop a merge.


// This is only for testing the switch sequencer. Will be removed if the espresso light client
// contract is ready and we will use another way to trigger the mode switching.
SetMode(ctx context.Context, espresso bool) error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my own clarification, the removal of this function does not imply the deprecation of SwitchToEspresso and SwitchToCentralized for the purposes of integration tests correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite clear what you meant. As you can see, the trigger to switch to another mode is our light client contract.


Before the contract was done, we had finished the switching functionality and that was why we chose to add a manual trigger to test the switch.

@ImJeremyHe ImJeremyHe merged commit 8237585 into integration Jul 13, 2024
7 of 8 checks passed
@ImJeremyHe ImJeremyHe deleted the jh/sync branch July 13, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet