-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New README [WIP] #309
New README [WIP] #309
Conversation
Current coverage is 36.07% (diff: 100%)@@ master #309 diff @@
==========================================
Files 46 46
Lines 2044 2118 +74
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 725 764 +39
- Misses 1319 1354 +35
Partials 0 0
|
What do you think, @goktugyil? |
Looking good, but need to add link to old examples, if the user wants detailed examples |
Generated by 🚫 danger |
I think thats going to change with the new version |
@Khalian what do you think? I'd like your input as well as @piv199 and @vilapuigvila's since that's an important decision |
Yea its pretty good. We might want to take down the CGRect example (its not that commonly used). |
Looks good now, you might want to squash your 5 commits to one (it isnt adding any extra information). |
Checklist
fixes #268 and #307 and #289 and #100