Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New README [WIP] #309

Merged
merged 5 commits into from
Nov 20, 2016
Merged

New README [WIP] #309

merged 5 commits into from
Nov 20, 2016

Conversation

lfarah
Copy link
Collaborator

@lfarah lfarah commented Nov 10, 2016

Checklist

  • New Extension
  • New Test
  • Changed more than one extension, but all changes are related
  • Trivial change (doesn't require changelog)

fixes #268 and #307 and #289 and #100

@codecov-io
Copy link

codecov-io commented Nov 10, 2016

Current coverage is 36.07% (diff: 100%)

Merging #309 into master will increase coverage by 0.60%

@@             master       #309   diff @@
==========================================
  Files            46         46          
  Lines          2044       2118    +74   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            725        764    +39   
- Misses         1319       1354    +35   
  Partials          0          0          

Powered by Codecov. Last update 099f6f0...82b9d15

@lfarah
Copy link
Collaborator Author

lfarah commented Nov 10, 2016

What do you think, @goktugyil?

@Esqarrouth
Copy link
Owner

  • Maybe change Usage to Example Usage
  • Easily get an object at a specified index: // I think there are better examples out there, or at least should show that it could return nil.

Looking good, but need to add link to old examples, if the user wants detailed examples

@lfarah
Copy link
Collaborator Author

lfarah commented Nov 17, 2016

@EZSwiftExtensionsBot
Copy link

EZSwiftExtensionsBot commented Nov 17, 2016

2 Messages
📖 Executed 145 tests, with 0 failures (0 unexpected) in 0.884 (1.085) seconds
📖 Executed 136 tests, with 0 failures (0 unexpected) in 0.830 (1.052) seconds

Generated by 🚫 danger

@Esqarrouth
Copy link
Owner

I think thats going to change with the new version

@lfarah
Copy link
Collaborator Author

lfarah commented Nov 18, 2016

@Khalian what do you think? I'd like your input as well as @piv199 and @vilapuigvila's since that's an important decision

@Khalian
Copy link
Collaborator

Khalian commented Nov 19, 2016

Yea its pretty good. We might want to take down the CGRect example (its not that commonly used).

@Khalian
Copy link
Collaborator

Khalian commented Nov 20, 2016

Looks good now, you might want to squash your 5 commits to one (it isnt adding any extra information).

@lfarah lfarah merged commit b5ebdd4 into master Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README Cleanup
5 participants