Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding set extension to UILabelExtensions (by vilapuigvila) #340

Merged
merged 1 commit into from Feb 5, 2017

Conversation

Khalian
Copy link
Collaborator

@Khalian Khalian commented Dec 15, 2016

Checklist

  • New Extension
  • New Test
  • Changed more than one extension, but all changes are related
  • Trivial change (doesn't require changelog)

@Khalian
Copy link
Collaborator Author

Khalian commented Dec 15, 2016

Squashing and removing edits to unrelated files from #302.

@Khalian Khalian mentioned this pull request Dec 15, 2016
4 tasks
@EZSwiftExtensionsBot
Copy link

EZSwiftExtensionsBot commented Dec 15, 2016

2 Messages
📖 Executed 179 tests, with 0 failures (0 unexpected) in 8.484 (8.750) seconds
📖 Executed 165 tests, with 0 failures (0 unexpected) in 4.043 (4.326) seconds

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Dec 15, 2016

Codecov Report

Merging #340 into master will increase coverage by -0.12%.

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   39.35%   39.24%   -0.12%     
==========================================
  Files          47       47              
  Lines        2175     2171       -4     
==========================================
- Hits          856      852       -4     
  Misses       1319     1319
Impacted Files Coverage Δ
Sources/UILabelExtensions.swift 50% <100%> (-6.25%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b4622...5a0db3d. Read the comment docs.

@Khalian
Copy link
Collaborator Author

Khalian commented Feb 5, 2017

So I cannot approve this, since I posted the PR on behalf of @vilapuigvila in the first place.

@Khalian Khalian force-pushed the vilapuigvila-uilabel_changes branch from ddd5002 to 5a0db3d Compare February 5, 2017 08:19
@Khalian Khalian merged commit 3814074 into master Feb 5, 2017
@Khalian Khalian deleted the vilapuigvila-uilabel_changes branch February 5, 2017 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
EZSwiftExtensions
Version 1.8.1
Development

Successfully merging this pull request may close these issues.

None yet

6 participants