<Description> : Removing for each since its already in the std library. #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfarah
requested changes
Feb 19, 2017
Sources/ArrayExtensions.swift
Outdated
| /// EZSE: Creates an array with values generated by running each value of self | ||
| /// through the mapFunction and discarding nil return values. | ||
| @available(*, deprecated: 1.6, renamed: "flatMap(_:)") | ||
| public func mapFilter<V>(mapFunction map: (Element) -> (V)?) -> [V] { | ||
| return flatMap { map($0) } | ||
| } | ||
|
|
||
| /// EZSE: Iterates on each element of the array with its index. (Index, Element) | ||
| /// EZSE: Iterates on each element of the array with its index. (Index, Eforlement) |
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 39.42% 39.45% +0.03%
==========================================
Files 47 47
Lines 2174 2172 -2
==========================================
Hits 857 857
+ Misses 1317 1315 -2
Continue to review full report at Codecov.
|
Khalian
force-pushed
the
removeforeach
branch
from
07df430
to
26e7dc5
Compare
lfarah
approved these changes
Feb 20, 2017
DanielAsher
reviewed
Feb 20, 2017
There was a problem hiding this comment.
hi - it looks like you will need to remove the following extension method for this to avoid name collision with the standard library:
@available(*, deprecated: 1.7, renamed: "forEachEnumerated(_:)")
public func forEach(_ call: @escaping (Int, Element) -> Void) {
forEachEnumerated(call)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
: fix
Checklist