Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Description> : Changing keyboardDidShowWithFrame from UIViewController extensions access modifier to open. #402

Merged
merged 1 commit into from
Mar 26, 2017
Merged

<Description> : Changing keyboardDidShowWithFrame from UIViewController extensions access modifier to open. #402

merged 1 commit into from
Mar 26, 2017

Conversation

Khalian
Copy link
Collaborator

@Khalian Khalian commented Mar 24, 2017

: fix

$ SIM/TT:

Checklist

  • New Extension
  • New Test
  • Changed more than one extension, but all changes are related
  • Trivial change (doesn't require changelog)

@Khalian
<Description> : Changing keyboardDidShowWithFrame from UIViewControll…
2f7aa0f 
…er extensions access

modifier to open.

<Type> : fix

$ SIM/TT:
@Khalian Khalian mentioned this pull request Mar 24, 2017
Open
@Khalian
Copy link
Collaborator Author

Khalian commented Mar 24, 2017

Addressing #401

@EZSwiftExtensionsBot
Copy link

EZSwiftExtensionsBot commented Mar 24, 2017 •
edited
Loading

2 Messages
📖 Executed 183 tests, with 0 failures (0 unexpected) in 8.255 (8.560) seconds
📖 Executed 169 tests, with 0 failures (0 unexpected) in 5.419 (5.726) seconds

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files          48       48           
  Lines        2179     2179           
=======================================
  Hits          868      868           
  Misses       1311     1311
Impacted Files Coverage Δ
Sources/UIViewControllerExtensions.swift 3.17% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b22f43...2f7aa0f. Read the comment docs.

@Khalian Khalian merged commit 25e9d61 into master Mar 26, 2017
@Khalian Khalian deleted the open branch March 26, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfarah lfarah lfarah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Khalian @EZSwiftExtensionsBot @codecov-io @lfarah