-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overloaded -timePassed method with language agnostic implementation #486
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // | ||
| // TimePassed.swift | ||
| // EZSwiftExtensions | ||
| // | ||
| // Created by Jaja Yting on 24/08/2018. | ||
| // Copyright © 2018 Goktug Yilmaz. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| public enum TimePassed { | ||
|
|
||
| case year(Int) | ||
| case month(Int) | ||
| case day(Int) | ||
| case hour(Int) | ||
| case minute(Int) | ||
| case second(Int) | ||
| case now | ||
| } | ||
|
|
||
| extension TimePassed: Equatable { | ||
|
|
||
| public static func ==(lhs: TimePassed, rhs: TimePassed) -> Bool { | ||
|
|
||
| switch(lhs, rhs) { | ||
|
|
||
| case (.year(let a), .year(let b)): | ||
| return a == b | ||
|
|
||
| case (.month(let a), .month(let b)): | ||
| return a == b | ||
|
|
||
| case (.day(let a), .day(let b)): | ||
| return a == b | ||
|
|
||
| case (.hour(let a), .hour(let b)): | ||
| return a == b | ||
|
|
||
| case (.minute(let a), .minute(let b)): | ||
| return a == b | ||
|
|
||
| case (.second(let a), .second(let b)): | ||
| return a == b | ||
|
|
||
| case (.now, .now): | ||
| return true | ||
|
|
||
| default: | ||
| return false | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if you have to represent something like 1 year and 6 months. IMO it should be both TimePassed.year(1) and TimePassed.month(6). Here it would just round up to 1 year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it would just round up to the largest time unit, because we retained the original behaviour of the first
-timePassedextension method. The original method would return"1 year ago", instead of"1 year and 6 months ago".On developers' (consumers') perspective, you're still right on what the
-timePassedmethod should return.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes fair point. I just looked up the impl.
The logic given that impl is fine, but that is something that might be construed as incorrect. I will think about how to deprecate that version and actually fix that impl with a better impl, but this is fine for now.