Skip to content
This repository has been archived by the owner on Mar 31, 2020. It is now read-only.

Misspelling for geometry filter? #348

Closed
geolibrerian opened this issue Jun 19, 2017 · 2 comments
Closed

Misspelling for geometry filter? #348

geolibrerian opened this issue Jun 19, 2017 · 2 comments

Comments

@geolibrerian
Copy link

ArcRest or ArcRestHelper

ArcRest

Version or date of download

import arcrest
arcrest.version
'3.5.9'

Bug or Enhancement

At lines 1604 and 1611 of ArcREST/src/arcrest/agol/services.py, the feature layer query geometry filter is defined as "geomtryFilter", instead of "geometryFilter", as defined in the documentation.
Note the missing 'e' in geomtryFilter

Documentation:
http://esri.github.io/ArcREST/arcrest.agol.html#arcrest.agol.services.FeatureLayer.query

Check here for confirmation
https://github.com/Esri/ArcREST/search?utf8=%E2%9C%93&q=geomtry&type=

Repo Steps or Enhancement details

I'm unsure if this misspelling is a bug or not. I'm assuming it is, based on the documentation describing the parameter as geometryFilter.

Thanks a lot for this package. It's a really useful tool!!!

@MikeMillerGIS
Copy link
Member

Thanks, since it was just a misspelling of an object, did not affect anything, but fixed it anyways.

@geolibrerian
Copy link
Author

Awesome, thanks. I found that it affected my layer queries, as the FeatureLayer objects returned by the FeatureService class relied on that keyword for the geometry filter. I'm glad it's adjusted, and appreciate the quick response!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants