This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Fixes to TypeScript type definition file #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛 fix: TypeScript type definition file was not included in package.json. fixes #296
jgravois
suggested changes
Mar 8, 2017
test.ts
Outdated
|
|
||
| console.assert(typeof Terraformer !== undefined); | ||
|
|
||
| let point = new Terraformer.Primitive({ | ||
| type: "Point", | ||
| coordinates: [1, 2] | ||
| coordinates: [1, 2], |
There was a problem hiding this comment.
are the new trailing commas added automatically?
There was a problem hiding this comment.
once we clean them up, i think we'll be good to merge.
There was a problem hiding this comment.
I've added a TSLint test to npm run test:ts. The tslint config has been modified to disallow the trailing commas. (By default it requires them. I have no preference either way on this matter.)
There was a problem hiding this comment.
you're a hero. i'll find time to pull this down and kick the tires in the next couple of days.
Modified TypeScript files to pass TSLint test. Modified TSLint configuration.
jgravois
approved these changes
Mar 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296