Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Sample: Snap geometry edits #1442

Merged
merged 10 commits into from
May 9, 2024
Merged

New Sample: Snap geometry edits #1442

merged 10 commits into from
May 9, 2024

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented May 7, 2024

Description

Implemented new sample to demonstrate how to use the Geometry Editor to edit a geometry and align it to existing geometries on a map.

Updated the sample sync python script to generate proper redirects, this has caused a number of readme changes to be changed which are not directly relevant to the sample code.

Type of change

  • New sample implementation

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@duffh
Copy link
Collaborator Author

duffh commented May 7, 2024

Reviewers please review files in Geometry/SnapGeometryEdits

@duffh duffh assigned duffh and unassigned williambohrmann3 May 7, 2024
Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent sample. UI looks fantastic. Tested on WPF and MAUI Android (landscape works as well 😃), everything seems to be functioning correctly. My feedback is focused on comments which applies to all implementations.

@duffh duffh requested a review from Luiy0 May 8, 2024 12:21
Copy link
Collaborator

@Luiy0 Luiy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @duffh! I was able to test it with the .NET sample viewer. I've left some minor comments. Thanks!

@duffh duffh merged commit c14fd30 into main May 9, 2024
6 checks passed
@duffh duffh deleted the hduff/snap-geometry-edits branch May 9, 2024 10:07
github-actions bot pushed a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants