Update OnApplyTemplate() in BasemapGallery.Appearance.cs #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this modification, you can start BasemapGallery Collapsed and later change it to Visible work under .NetFramework 472. This change won't break .NET 6 side. Currently if you start BasemapGallery collapsed, you can never see loaded basemap list due to the fact that _loadingScrim never goes away under .Netframework 472.
Update BasemapGallery.Appearance.cs OnApplyTemplate()
|
Thank you for this. Are you not seeing this happen on .NET 6? If so I think this behavior might actually be due to a .NET Framework bug we just had to add a workaround for, and not a toolkit issue. |
|
I confirmed that this won't happen in NET6. My fix I submitted works for
both Framework and Net6.
Tosa
…On Thu, Feb 2, 2023 at 5:39 PM Morten Nielsen ***@***.***> wrote:
Thank you for this. Are you not seeing this happen on .NET 6? If so I
think this behavior might actually be due to a .NET Framework bug we just
had to add a workaround for, and not a toolkit issue.
—
Reply to this email directly, view it on GitHub
<#486 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMZ36QRVGFO5KMLFX6SYUDLWVQZTVANCNFSM6AAAAAAUA3XCEQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@soba-noodle Thanks for confirming. This is actually caused by a .NET Framework bug, that we have worked around in 200.1, so other tools (like this one) won't need to work around it. |
|
Can you tell when 200.1 is released? We like to release our app ASAP.
Thanks.
Tosa
…On Mon, Feb 6, 2023 at 8:31 PM Morten Nielsen ***@***.***> wrote:
@soba-noodle <https://github.com/soba-noodle> Thanks for confirming. This
is actually caused by a .NET Framework bug, that we have worked around in
200.1, so other tools (like this one) won't need to work around it.
—
Reply to this email directly, view it on GitHub
<#486 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMZ36QWGWBZY3ECGSM7PCYLWWGQYFANCNFSM6AAAAAAUA3XCEQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under NetFramework 472, BasemapGallery does not work when started as Collapsed. This update will allow BasemapGallery starts as Collapsed and when Visibility changed to Visible basemap items will be shown.