Fix cosmetic issues in PopupViewer on small screens #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstefarov
force-pushed
the
matvei/popup-sample-cosmetic-fix
branch
from
7334060
to
9ea5caa
Compare
dotMorten
reviewed
Nov 7, 2023
| <Grid> | ||
| <esriTK:PopupViewer x:Name="popupViewer" Padding="20" MaximumWidthRequest="400" HeightRequest="400" PopupAttachmentClicked="popupViewer_PopupAttachmentClicked" /> | ||
| <esriTK:PopupViewer x:Name="popupViewer" Padding="12" MaximumWidthRequest="400" MaximumHeightRequest="400" PopupAttachmentClicked="popupViewer_PopupAttachmentClicked" /> |
There was a problem hiding this comment.
Did you try this on all platforms? I seem to recall there's a reason we're using HeightRequest and not MaximumHeightRequest
There was a problem hiding this comment.
I now tested on all platforms, and the updated layout works well everywhere.
williambohrmann3
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dotnet-api#11813
Improve appearance of PopupViewer sample on small screens by allowing height smaller than 400 dips, and by slightly reducing margins. In a more complex app, margins would probably be adjusted by VisualState triggers, but this compromise value keeps things looking decent on all screens.
Before:
After:
