Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeatureForm WPF: Tooltip shows even when empty #561

Merged
merged 7 commits into from
Mar 26, 2024
Merged

FeatureForm WPF: Tooltip shows even when empty #561

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0c70e2e
Adding Visibility toggle based on content of `Hint` Property using Vi…
prathameshnarkhede Mar 14, 2024
ca4505e
Restoring space
prathameshnarkhede Mar 14, 2024
d5e1847
Restoring spaces
prathameshnarkhede Mar 14, 2024
a4450d9
Restoring spaces
prathameshnarkhede Mar 14, 2024
ec93866
Changing Tooltip visibility code from ValueConverter to Triggers.
prathameshnarkhede Mar 25, 2024
d951b29
Reverting automatic refactoring spaces
prathameshnarkhede Mar 25, 2024
7607804
Restoring automatic refactored spaces
prathameshnarkhede Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/Toolkit/Toolkit.WPF/UI/Controls/FeatureForm/FeatureFormView.Theme.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
xmlns:internal="clr-namespace:Esri.ArcGISRuntime.Toolkit.Internal"
xmlns:controls="clr-namespace:Esri.ArcGISRuntime.Toolkit.UI.Controls"
xmlns:forms="clr-namespace:Esri.ArcGISRuntime.Mapping.FeatureForms;assembly=Esri.ArcGISRuntime"
xmlns:primitives="clr-namespace:Esri.ArcGISRuntime.Toolkit.Primitives">

xmlns:primitives="clr-namespace:Esri.ArcGISRuntime.Toolkit.Primitives"
xmlns:sys="clr-namespace:System;assembly=mscorlib">

<SolidColorBrush x:Key="FeatureFormAccentBrush" Color="#007AC2" />
<Thickness x:Key="FeatureFormElementInputMargin">0,0,0,5</Thickness>
<internal:VisibilityConverter x:Key="FeatureFormViewVisibilityConverter"/>
Expand Down Expand Up @@ -230,7 +231,24 @@
<ControlTemplate TargetType="{x:Type primitives:FieldFormElementView}">
<StackPanel>
<TextBlock Text="{Binding Label}" Style="{StaticResource FeatureFormViewTitleStyle}"/>
<ContentControl Margin="0,3" Foreground="Gray" Content="{Binding}" x:Name="FieldInput" ToolTip="{Binding Hint}" />
<ContentControl Margin="0,3" Foreground="Gray" Content="{Binding}" x:Name="FieldInput">
<ContentControl.ToolTip>
<ToolTip Content="{Binding Hint}">
<ToolTip.Style>
<Style TargetType="{x:Type ToolTip}">
<Style.Triggers>
<Trigger Property="Content" Value="{x:Static sys:String.Empty}">
<Setter Property="Visibility" Value="Collapsed"/>
</Trigger>
<Trigger Property="Content" Value="{x:Null}">
<Setter Property="Visibility" Value="Collapsed"/>
</Trigger>
</Style.Triggers>
</Style>
</ToolTip.Style>
</ToolTip>
</ContentControl.ToolTip>
</ContentControl>
prathameshnarkhede marked this conversation as resolved.
Show resolved Hide resolved
<TextBlock Text="{Binding Description}" Visibility="{Binding Description, Converter={StaticResource FeatureFormViewVisibilityConverter}}" Opacity=".7" Style="{StaticResource FeatureFormViewCaptionStyle}" />
<TextBlock Foreground="Red" x:Name="ErrorLabel" Visibility="{Binding Text, ElementName=ErrorLabel, Converter={StaticResource FeatureFormViewVisibilityConverter}}" />
</StackPanel>
Expand Down