[New] Show device location history #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is low priority, no hurry to review. |
dfeinzimer
previously approved these changes
Feb 11, 2023
Shared/Samples/Show device location history/ShowDeviceLocationHistoryView.swift
Outdated
Show resolved
Hide resolved
philium
reviewed
Feb 15, 2023
Shared/Samples/Show device location history/ShowDeviceLocationHistoryView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show device location history/ShowDeviceLocationHistoryView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show device location history/ShowDeviceLocationHistoryView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show device location history/ShowDeviceLocationHistoryView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show device location history/ShowDeviceLocationHistoryView.swift
Outdated
Show resolved
Hide resolved
philium
reviewed
Feb 16, 2023
Shared/Samples/Show device location history/ShowDeviceLocationHistoryView.swift
Outdated
Show resolved
Hide resolved
…HistoryView.swift Co-authored-by: Philip Ridgeway <philip.ridgeway@gmail.com>
philium
approved these changes
Feb 16, 2023
dfeinzimer
approved these changes
Feb 16, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Show device location historyinMapscategory.URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Ting/ShowLocationHistory/Shared/Samples/Show%20device%20location%20history
Linked Issue(s)
common-samples/issues/3820How To Test
Run the sample and see if the track always works, and the objects get deallocated correctly when the sample quits.
Screenshots
To Discuss
for await newLocation in locationDisplay.dataSource.locationssection is correct. This sample's key part is to demonstrate async stream is the equivalent oflocationChangedHandlerpattern.