[New] Authenticate with OAuth #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vquach2404
reviewed
Mar 17, 2023
Shared/Samples/Authenticate with OAuth/AuthenticateWithOAuthView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Authenticate with OAuth/AuthenticateWithOAuthView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Authenticate with OAuth/AuthenticateWithOAuthView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Vivian Quach <viv10382@esri.com>
yo1995
reviewed
Mar 17, 2023
There was a problem hiding this comment.
If I click on cancel when the login alert shows, it gives this warning
I don't think it matters, might just be a false alarm from UIKit.
2023-03-17 16:06:08.477191-0700 Samples[2855:10999341]
[Warning] Attempting to load the view of a view controller while it is deallocating is not allowed
and may result in undefined behavior (<SFAuthenticationViewController: 0x7fb94a09b200>)
Shared/Samples/Authenticate with OAuth/AuthenticateWithOAuthView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Authenticate with OAuth/AuthenticateWithOAuthView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Authenticate with OAuth/AuthenticateWithOAuthView.swift
Outdated
Show resolved
Hide resolved
yo1995
reviewed
Mar 21, 2023
There was a problem hiding this comment.
Will approve after Esri/arcgis-maps-sdk-swift-toolkit#276 is merged.
Shared/Samples/Authenticate with OAuth/AuthenticateWithOAuthView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Authenticate with OAuth/AuthenticateWithOAuthView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Authenticate with OAuth/AuthenticateWithOAuthView.swift
Outdated
Show resolved
Hide resolved
yo1995
approved these changes
Mar 21, 2023
vquach2404
approved these changes
Mar 21, 2023
|
Thanks @yo1995 and @vquach2404! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Authenticate with OAuthinCloud and portalcategory.URL to README: README
Linked Issue(s)
serenity/issues/1406How To Test
Screenshots