Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] Download preplanned map area 2 #134

Merged
merged 94 commits into from
Mar 30, 2023
Merged

[New] Download preplanned map area 2 #134

merged 94 commits into from
Mar 30, 2023

Conversation

rolson
Copy link
Contributor

@rolson rolson commented Mar 22, 2023 •
edited by yo1995

Description

This PR implements Download preplanned map area in Maps category.
URL to README: URL

Note: This addresses the issues with the previous PR.

Linked Issue(s)

  • swift/issues/2256

How To Test

  1. Tap "Select Map".
  2. Download various preplanned maps and wait for them to download.
  3. Switch between different downloaded preplanned maps.
  4. Delete the downloaded maps by tapping on the trash can icon.

Screenshots

download-preplanned-map-area

yo1995 and others added 30 commits May 26, 2022 12:18
@yo1995
Create PULL_REQUEST_TEMPLATE.md
3ca165b
@yo1995
Merge pull request #9 from ArcGIS/Ting/PR-Template
31e10c1 
[Setup] Create PULL_REQUEST_TEMPLATE.md
@clee088
Add download preplanned map area sample
d1fc570
@clee088
Add custom sheet
fa513f5
@clee088
Add navigation view to sheet content
0ccf3f5
@clee088
Update screenshot
caadf18
@clee088
Move sheet modifier to toolbar button
fc9feb2
@clee088
Update View+Sheet.swift
6de9f78
@clee088
Update alert and remove files in deinit
079bf2e
@clee088
Merge branch 'v.next' into clee/New-DownloadPreplannedMapArea
20e132a
@clee088
Merge branch 'v.next' into clee/New-DownloadPreplannedMapArea
9d88424
@clee088
Add sample to code files
1307d0b
@clee088
Update load preplanned map areas method
f0293a8
@clee088
Update cancel and deinit
81c2a8e
@clee088
Don't dismiss an alert
ac9a6aa
@clee088
Merge branch 'clee/New-SheetExtension' into clee/New-DownloadPreplann…
58fd090 
…edMapArea
@clee088
Revert alert workaround
2546fda
@clee088
Isolate creation of parameters
1c01189
@clee088
Reformat file
94a4977
@clee088
Update cancel all jobs methods
7715567
@clee088
Fix indentation
5b7739b
@clee088
Update portalItem
1b6b7af
@clee088
Merge branch 'v.next' into clee/New-DownloadPreplannedMapArea
ea81b87
@clee088
Merge branch 'v.next' into clee/New-DownloadPreplannedMapArea
ede1b44
@clee088
Fix portal item
6232e8e
@clee088
Fix temporary directory
4e34dcc
@clee088
Use error did set
0568df2
@clee088
Fix makeDownloadPreplannedOfflineMapParameters
94ed31c
@clee088
Update result handling
8cdeaba
@clee088
Simplify cancel all jobs method
b42e174
mhdostal
mhdostal requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@mhdostal mhdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I like the Gauge progress view style. Very slick.

Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.Model.swift Outdated Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.swift Outdated Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.swift Outdated Show resolved Hide resolved
@mhdostal
Copy link
Member

Please retake the screenshot with the iPhone 11 simulator to remove the Dynamic Island.

rolson and others added 3 commits March 28, 2023 09:23
@rolson @mhdostal
Update Shared/Samples/Download preplanned map area/DownloadPreplanned…
886ba5a 
…MapAreaView.Model.swift

Co-authored-by: Mark Dostal <mhdostal@aol.com>
@rolson
cleanup
e98d49a
@rolson
PR feedback
02def27
@rolson rolson requested a review from mhdostal March 28, 2023 15:36
mhdostal
mhdostal previously approved these changes Mar 28, 2023
View reviewed changes
@yo1995 yo1995 mentioned this pull request Mar 28, 2023
Closed
yo1995
yo1995 reviewed Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly phrasing changes. Overall the sample is working well. Thanks @clee088 for the initial contribution!

Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.swift Outdated Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.Model.swift Outdated Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.swift Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.Model.swift Outdated Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.Model.swift Outdated Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.Model.swift Outdated Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.Model.swift Outdated Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.Model.swift Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.Model.swift Outdated Show resolved Hide resolved
Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.Model.swift Outdated Show resolved Hide resolved
@rolson @yo1995
Apply suggestions from code review
518c8f0 
Co-authored-by: Ting <tchen@esri.com>
@rolson rolson requested review from mhdostal and yo1995 March 29, 2023 22:16
@rolson
Copy link
Contributor Author

rolson commented Mar 29, 2023

Thanks @clee088 for the initial contribution!

Yes, thank you for your work on this @clee088.

@rolson
Copy link
Contributor Author

rolson commented Mar 29, 2023

This looks really good. I like the Gauge progress view style. Very slick.

I like it as well. AFAIK @clee088 built it.

@rolson
Copy link
Contributor Author

rolson commented Mar 29, 2023

Fixed project file merge conflicts. This is still ready for re-review.

yo1995
yo1995 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the joint effort on this huge sample!

@rolson rolson merged commit 4917b64 into v.next Mar 30, 2023
@rolson rolson deleted the ryan/downloadPreplanned branch March 30, 2023 15:02
@yo1995 yo1995 mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdostal mhdostal mhdostal approved these changes

@yo1995 yo1995 yo1995 approved these changes

Assignees

@rolson rolson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rolson @mhdostal @yo1995 @clee088