-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Search with geocode #14
Conversation
@TADraeseke I included you to take a look at this quasi-design as well as other phrasing issues. Feel free to ignore if you don't have time. 🙂 |
Adjust comment column width. Co-authored-by: David Feinzimer <dfeinzimer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but based on the screenshot, it looks like there is more padding on the leading edge of the search view than on the trailing edge. Is there anything that can be done about that?
Co-authored-by: Philip Ridgeway <philip.ridgeway@gmail.com>
It seems like there is a spacer in the search view's HStack: https://github.com/ArcGIS/arcgis-runtime-toolkit-swift/blob/v.next/Sources/ArcGISToolkit/Components/Search/SearchView.swift#L119 , though I'm not sure why 🤔 |
The |
Yeah, I missed that - it's not centered in the first place. I think it's fine to put it on the right. |
Thanks for your prompt review! I'll merge this PR after samples team review tomorrow morning. |
Description
This PR implements
Search with geocode
inSearch
category.URL to README: https://github.com/ArcGIS/arcgis-runtime-samples-swift/tree/Ting/New-FindAddressGeocode/Shared/Samples/Search%20with%20geocode
Linked Issue(s)
common-samples/issues/3110
How To Test
Screenshots
220602-geocode-demo.mp4
To Discuss
Find address
andFind place
to write this README. With the help of toolkit, theHow it works
section is significantly simplified. Please let me know if any essential info is missing from the README!