Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] 200.1.0 ArcGIS Bundle ID #141

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

zkline101
Copy link
Contributor

Description

This PR updates the ArcGIS Bundle ID which prevents a crash when clicking on the about button.

@zkline101 zkline101 requested a review from yo1995 March 23, 2023 22:20
@zkline101 zkline101 self-assigned this Mar 23, 2023
@yo1995 yo1995 changed the title Update ArcGIS Bundle ID [Update] 200.1.0 ArcGIS Bundle ID Mar 23, 2023
Copy link

@saratchandrakarumuri saratchandrakarumuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App is still crashing for me when I open the info pane

2023-03-23 at 5 47 PM

@zkline101
Copy link
Contributor Author

@saratchandrakarumuri Which version of the Swift SDK are you using in the samples app?

@yo1995
Copy link
Collaborator

yo1995 commented Mar 24, 2023

Sorry Sarat I should mention, this need to be tested with the local toolkit folder and ArcGIS daily build binary, because…

  • 200.0.0-beta doesn't have the same bundle ID
  • The source code local Swift package uses a different bundle ID ("ArcGIS" instead of "com.esri.ArcGIS", for some reason). Only the binary is using the "com.esri.ArcGIS" bundle ID.

@saratchandrakarumuri
Copy link

@yo1995 Ahhh... Makes sense... I tried with the source code swift package... I will try with daily build now

Copy link

@saratchandrakarumuri saratchandrakarumuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looking good

@zkline101
Copy link
Contributor Author

Thank you both

@zkline101 zkline101 merged commit 9dd0af7 into v.next Mar 24, 2023
@zkline101 zkline101 deleted the zach/updateArcGISBundleID branch March 24, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants