Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] Change camera controller #152

Merged
merged 18 commits into from
Apr 10, 2023
Merged

[New] Change camera controller #152

merged 18 commits into from
Apr 10, 2023

Conversation

des12437
Copy link
Contributor

@des12437 des12437 commented Apr 4, 2023 •
edited by yo1995

Description

This PR implements Change camera controller in Scenes category.
URL to README: URL

Linked Issue(s)

  • swift/issues/2261

How To Test

  • Tap the Camera controllers button to select a type of camera controller.
  • Orbit camera around crater fixes the camera above a crater.
  • Orbit camera around plane fixes the camera above a plane.
  • Free pan round the globe allows panning the Scene.

Screenshots

choose-camera-controller

@des12437 des12437 requested a review from yo1995 April 4, 2023 16:09
@des12437 des12437 self-assigned this Apr 4, 2023
yo1995
yo1995 reviewed Apr 6, 2023
View reviewed changes
Shared/Samples/Choose camera controller/ChooseCameraControllerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Choose camera controller/ChooseCameraControllerView.swift Outdated Show resolved Hide resolved
Samples.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Shared/Samples/Choose camera controller/README.md Outdated Show resolved Hide resolved
Shared/Samples/Choose camera controller/ChooseCameraControllerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Choose camera controller/ChooseCameraControllerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Choose camera controller/ChooseCameraControllerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Choose camera controller/ChooseCameraControllerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Choose camera controller/ChooseCameraControllerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Choose camera controller/ChooseCameraControllerView.swift Outdated Show resolved Hide resolved
@yo1995 yo1995 changed the title [New] Choose camera controller [New] Change camera controller Apr 6, 2023
@des12437 des12437 requested a review from yo1995 April 6, 2023 22:57
yo1995
yo1995 reviewed Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve with the following changes.

Shared/Samples/Change camera controller/ChangeCameraControllerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Change camera controller/ChangeCameraControllerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Change camera controller/ChangeCameraControllerView.swift Show resolved Hide resolved
@des12437 des12437 requested a review from yo1995 April 7, 2023 17:07
@yo1995 yo1995 requested a review from mhdostal April 7, 2023 17:19
@des12437 des12437 merged commit 6476da1 into v.next Apr 10, 2023
1 check passed
@des12437 des12437 deleted the des12437/Choose-camera-controller branch April 10, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdostal mhdostal mhdostal approved these changes

@yo1995 yo1995 yo1995 approved these changes

Assignees

@des12437 des12437

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@des12437 @mhdostal @yo1995