Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Compile error related to Item.id #161

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

zkline101
Copy link
Contributor

@zkline101 zkline101 commented Apr 6, 2023

Description

ting: See Swift 3906 - it involves a bug in Item.ID's optionality, and the final solution is hard to explain in a few words.

@zkline101 zkline101 self-assigned this Apr 6, 2023
@yo1995 yo1995 changed the title Fix compile error related to Item.id [Fix] Compile error related to Item.id Apr 7, 2023
Copy link
Contributor

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one open discussion from Ting

@yo1995
Copy link
Collaborator

yo1995 commented Apr 7, 2023

Should be ready to merge. Will create the dummy app after this.

@zkline101 zkline101 merged commit 5dc9758 into v.next Apr 7, 2023
1 check passed
@zkline101 zkline101 deleted the zach/updateItemId branch April 7, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants