Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] Address UI feedback from Nick #165

Merged
merged 14 commits into from
Apr 12, 2023
Merged

[Update] Address UI feedback from Nick #165

merged 14 commits into from
Apr 12, 2023

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented Apr 11, 2023

Description

This PR updates various feedback from Nick on the initial testing for 200.1.0 sample viewer TestFlight app.

Linked Issue(s)

  • swift/issues/3931

How To Test

  • Verify all changed samples are still functionally same as before
  • Double check if other screenshots need to be updated

@yo1995 yo1995 requested review from nixta and dfeinzimer April 11, 2023 18:03
@yo1995 yo1995 self-assigned this Apr 11, 2023
@yo1995 yo1995 requested a review from dfeinzimer April 11, 2023 22:01
dfeinzimer
dfeinzimer approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to light and shadows looks nice

nixta
nixta approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@nixta nixta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually built and run, but from the screenshots it looks great. Thank you!

@yo1995
Copy link
Collaborator Author

yo1995 commented Apr 12, 2023

Thank you Nick for the feedback! No worries, all the changes will be verified by Sarat again.

@yo1995 yo1995 merged commit f9d6a8c into v.next Apr 12, 2023
1 check passed
@yo1995 yo1995 deleted the Ting/FixNickUI branch April 12, 2023 17:44
@yo1995 yo1995 mentioned this pull request Dec 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixta nixta nixta approved these changes

@dfeinzimer dfeinzimer dfeinzimer approved these changes

Assignees

@yo1995 yo1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yo1995 @nixta @dfeinzimer