Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Setup] Fix local bundle ID caused crash #177

Merged
merged 1 commit into from
Apr 21, 2023
Merged

[Setup] Fix local bundle ID caused crash #177

merged 1 commit into from
Apr 21, 2023

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented Apr 20, 2023 •
edited

Description

This PR fixes the info button crash when developing using a local source code package.

Linked Issue(s)

How To Test

  1. Build without changing the project file. It resolves to the 200.1 released binary package
  2. Build after changing the project file to use the local source package.
  3. Tap on info button and no crash.
  4. You can also test build with swift-daily.

@yo1995 yo1995 self-assigned this Apr 20, 2023
@yo1995 yo1995 linked an issue Apr 20, 2023 that may be closed by this pull request
Crash when pressing main info button #157
Closed
dfeinzimer
dfeinzimer approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crash appears to be gone!

The SDK version number is still wrong when using the GitHub package
Screenshot 2023-04-20 at 16 55 15

But okay when using binaries. Any idea why?
Screenshot 2023-04-20 at 16 53 32

@yo1995
Copy link
Collaborator Author

yo1995 commented Apr 21, 2023

The SDK version number is still wrong when using the GitHub package, but okay when using binaries.

Please see CreatePackage.swift around line 268. The version and build numbers are injected when the package is built. By default it is 1.0 I believe.

@yo1995 yo1995 merged commit 94cabb6 into v.next Apr 21, 2023
1 check passed
@yo1995 yo1995 deleted the Ting/FixBundleID branch April 21, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saratchandrakarumuri saratchandrakarumuri saratchandrakarumuri approved these changes

@dfeinzimer dfeinzimer dfeinzimer approved these changes

Assignees

@yo1995 yo1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when pressing main info button
3 participants
@yo1995 @saratchandrakarumuri @dfeinzimer