Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Set min and max scale #181

Merged
merged 16 commits into from
May 24, 2023
Merged

[New] Set min and max scale #181

merged 16 commits into from
May 24, 2023

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements Set min and max scale in Maps category.
URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-SetMinMaxScale/Shared/Samples/Set%20min%20and%20max%20scale

Linked Issue(s)

  • swift/issues/4086

How To Test

  • Spread to zoom in to the min scale.
  • Pinch to zoom out to the max scale.

Screenshots

set-min-and-max-scale

@CalebRas CalebRas requested a review from yo1995 May 22, 2023 21:02
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments on the metadata. Good job!

Shared/Samples/Set min and max scale/README.md Outdated Show resolved Hide resolved
Shared/Samples/Set min and max scale/README.md Outdated Show resolved Hide resolved
Shared/Samples/Set min and max scale/README.md Outdated Show resolved Hide resolved
Shared/Samples/Set min and max scale/README.metadata.json Outdated Show resolved Hide resolved
Shared/Samples/Set min and max scale/README.metadata.json Outdated Show resolved Hide resolved
@yo1995 yo1995 requested a review from dfeinzimer May 22, 2023 23:59
@CalebRas CalebRas merged commit 625984c into v.next May 24, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-SetMinMaxScale branch May 24, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants