Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Style point with picture marker symbols #182

Merged
merged 38 commits into from
May 30, 2023

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements Style point with picture marker symbols in Display information category.
URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-PictureMarkerSymbols/Shared/Samples/Style%20point%20with%20picture%20marker%20symbols

Linked Issue(s)

  • swift/issues/4087

How To Test

Screenshots

style-point-with-picture-marker-symbols

@CalebRas CalebRas requested a review from yo1995 May 23, 2023 21:52
@CalebRas CalebRas changed the title Caleb/new picture marker symbols [New] Style point with picture marker symbols May 23, 2023
CalebRas and others added 6 commits May 25, 2023 11:17
…intWithPictureMarkerSymbolsView.swift

Co-authored-by: Ting <tchen@esri.com>
…intWithPictureMarkerSymbolsView.swift

Co-authored-by: Ting <tchen@esri.com>
…intWithPictureMarkerSymbolsView.swift

Co-authored-by: Ting <tchen@esri.com>
…intWithPictureMarkerSymbolsView.swift

Co-authored-by: Ting <tchen@esri.com>
…intWithPictureMarkerSymbolsView.swift

Co-authored-by: Ting <tchen@esri.com>
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see Phil's comment.

yo1995
yo1995 previously approved these changes May 25, 2023
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this sample! Can you do one more re-indent of the whole file? For some reason the whitespaces aren't consistent in it.

yo1995
yo1995 previously approved these changes May 25, 2023
yo1995
yo1995 previously approved these changes May 26, 2023
@yo1995 yo1995 requested review from philium and removed request for philium May 26, 2023 21:48
@yo1995 yo1995 requested review from mhdostal and removed request for philium May 30, 2023 18:26
@yo1995
Copy link
Collaborator

yo1995 commented May 30, 2023

Phil is busy with other stuff so I added Mark to take a look.

@CalebRas CalebRas requested a review from mhdostal May 30, 2023 20:33
…intWithPictureMarkerSymbolsView.swift

Co-authored-by: Mark Dostal <mhdostal@aol.com>
CalebRas and others added 2 commits May 30, 2023 14:24
…intWithPictureMarkerSymbolsView.swift

Co-authored-by: Mark Dostal <mhdostal@aol.com>
…intWithPictureMarkerSymbolsView.swift

Co-authored-by: Mark Dostal <mhdostal@aol.com>
Copy link
Member

@mhdostal mhdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@CalebRas CalebRas requested a review from yo1995 May 30, 2023 21:28
@CalebRas CalebRas merged commit f7748a9 into v.next May 30, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-PictureMarkerSymbols branch May 30, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants