Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Add WMS layer #188

Merged
merged 20 commits into from
May 30, 2023
Merged

[New] Add WMS layer #188

merged 20 commits into from
May 30, 2023

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements Add WMS layer in Layers category.
URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-AddWMSLayer/Shared/Samples/Add%20WMS%20layer

Linked Issue(s)

  • swift/issues/4083

How To Test

Screenshots

add-wms-layer

@CalebRas CalebRas requested a review from yo1995 May 26, 2023 21:16
@CalebRas CalebRas self-assigned this May 26, 2023
Shared/Samples/Add WMS layer/AddWMSLayerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Add WMS layer/AddWMSLayerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Add WMS layer/README.md Outdated Show resolved Hide resolved
Shared/Samples/Add WMS layer/README.md Outdated Show resolved Hide resolved
CalebRas and others added 3 commits May 26, 2023 15:17
Co-authored-by: Ting <tchen@esri.com>
Co-authored-by: Ting <tchen@esri.com>
@yo1995 yo1995 requested a review from dfeinzimer May 26, 2023 22:22
@CalebRas CalebRas requested a review from yo1995 May 26, 2023 22:37
Co-authored-by: David Feinzimer <dfeinzimer@gmail.com>
dfeinzimer
dfeinzimer previously approved these changes May 26, 2023
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment issues. Otherwise approved!

Shared/Samples/Add WMS layer/AddWMSLayerView.swift Outdated Show resolved Hide resolved
Shared/Samples/Add WMS layer/AddWMSLayerView.swift Outdated Show resolved Hide resolved
CalebRas and others added 2 commits May 30, 2023 09:17
@CalebRas CalebRas requested a review from dfeinzimer May 30, 2023 16:38
@CalebRas CalebRas merged commit 2355d85 into v.next May 30, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-AddWMSLayer branch May 30, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants