-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Show coordinates in multiple formats #190
Conversation
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
…natesInMultipleFormatsView.swift Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift Co-authored-by: Zachary A Kline <zkline@esri.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another problem I noticed is when the sample is in iPhone 14 PM landscape orientation, the textfields take up the entire screen. I don't think it is an issue or a need to add a scroll view as no one gonna use the sample that way. 😼
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
…natesInMultipleFormatsView.swift Co-authored-by: Ting <tchen@esri.com>
…natesInMultipleFormatsView.swift Co-authored-by: Ting <tchen@esri.com>
…natesInMultipleFormatsView.swift Co-authored-by: Ting <tchen@esri.com>
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
…natesInMultipleFormatsView.swift Co-authored-by: Ting <tchen@esri.com>
…natesInMultipleFormatsView.swift Co-authored-by: Ting <tchen@esri.com>
Shared/Samples/Show coordinates in multiple formats/ShowCoordinatesInMultipleFormatsView.swift
Outdated
Show resolved
Hide resolved
Shouldn't we fix that though? We can't really predict how the user is going to use the app but I think we should make sure the sample looks right in all scenrios. |
I was afraid that might be too much for Caleb to implement, and add a lot of adaptive UI code that isn't related to the sample. But I'm happy if Caleb want to try that out, either with an adaptive stack view like the old sample, or sth like a LazyVGrid in a scroll view. |
I personally think that adding additional code to handle the landscape orientation would distract from the point of the sample, but would be willing to try to fix it if you guys want. Is there possibly a way to disable rotation just for this view? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want, you can add a note and rework the UI in the second half of the internship.
Description
This PR implements
Show coordinates in multiple formats
inGeometry
category.URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-FormatCoordinates/Shared/Samples/Show%20coordinates%20in%20multiple%20formats
Linked Issue(s)
swift/issues/4129
How To Test
Screenshots