Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Show coordinates in multiple formats #190

Merged
merged 29 commits into from
Jun 12, 2023

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements Show coordinates in multiple formats in Geometry category.
URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-FormatCoordinates/Shared/Samples/Show%20coordinates%20in%20multiple%20formats

Linked Issue(s)

  • swift/issues/4129

How To Test

  • Tap on the map to see the different coordinate formats for the tapped point.

Screenshots

show-coordinates-in-multiple-formats

@CalebRas CalebRas requested a review from yo1995 May 31, 2023 18:55
@CalebRas CalebRas self-assigned this May 31, 2023
@yo1995 yo1995 requested a review from zkline101 June 6, 2023 02:54
@CalebRas CalebRas requested a review from yo1995 June 6, 2023 16:37
CalebRas and others added 9 commits June 7, 2023 09:59
…natesInMultipleFormatsView.swift

Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift

Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift

Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift

Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift

Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift

Co-authored-by: Zachary A Kline <zkline@esri.com>
…natesInMultipleFormatsView.swift

Co-authored-by: Zachary A Kline <zkline@esri.com>
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another problem I noticed is when the sample is in iPhone 14 PM landscape orientation, the textfields take up the entire screen. I don't think it is an issue or a need to add a scroll view as no one gonna use the sample that way. 😼

CalebRas and others added 4 commits June 8, 2023 12:48
…natesInMultipleFormatsView.swift

Co-authored-by: Ting <tchen@esri.com>
…natesInMultipleFormatsView.swift

Co-authored-by: Ting <tchen@esri.com>
…natesInMultipleFormatsView.swift

Co-authored-by: Ting <tchen@esri.com>
@CalebRas CalebRas requested review from yo1995 and zkline101 June 8, 2023 20:09
CalebRas and others added 3 commits June 9, 2023 09:44
…natesInMultipleFormatsView.swift

Co-authored-by: Ting <tchen@esri.com>
…natesInMultipleFormatsView.swift

Co-authored-by: Ting <tchen@esri.com>
yo1995
yo1995 previously approved these changes Jun 12, 2023
@zkline101
Copy link
Contributor

Another problem I noticed is when the sample is in iPhone 14 PM landscape orientation, the textfields take up the entire screen. I don't think it is an issue or a need to add a scroll view as no one gonna use the sample that way. 😼

Shouldn't we fix that though? We can't really predict how the user is going to use the app but I think we should make sure the sample looks right in all scenrios.

@yo1995
Copy link
Collaborator

yo1995 commented Jun 12, 2023

I was afraid that might be too much for Caleb to implement, and add a lot of adaptive UI code that isn't related to the sample. But I'm happy if Caleb want to try that out, either with an adaptive stack view like the old sample, or sth like a LazyVGrid in a scroll view.

@CalebRas
Copy link
Contributor Author

I personally think that adding additional code to handle the landscape orientation would distract from the point of the sample, but would be willing to try to fix it if you guys want. Is there possibly a way to disable rotation just for this view?

Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you can add a note and rework the UI in the second half of the internship.

@CalebRas CalebRas merged commit 2cccc17 into v.next Jun 12, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-FormatCoordinates branch June 12, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants