Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Set up location-driven geotriggers #198

Merged
merged 39 commits into from
Jul 7, 2023

Conversation

CalebRas
Copy link
Contributor

@CalebRas CalebRas commented Jun 7, 2023

Description

This PR implements Set up location-driven geotriggers in Display information category.
URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-SetUpLocationDrivenGeotrigers/Shared/Samples/Set%20up%20location-driven%20geotriggers

Linked Issue(s)

  • swift/issues/4135

How To Test

  • Watch the location display move and the status texts change accordingly.
  • Tap the "Current Section" button to see the current section information when available.
  • Tap the "Point of Interest" button to see the point of interest information when available.

Screenshots

set-up-location-driven-geotriggers

@CalebRas CalebRas requested a review from yo1995 June 7, 2023 22:47
@CalebRas CalebRas self-assigned this Jun 7, 2023
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments.

@CalebRas CalebRas requested a review from yo1995 June 15, 2023 17:44
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting into the concurrency deep water! 🎣

CalebRas and others added 3 commits June 16, 2023 08:10
…nDrivenGeotriggersView.swift

Co-authored-by: Ting <tchen@esri.com>
…nDrivenGeotriggersView.swift

Co-authored-by: Ting <tchen@esri.com>
@CalebRas CalebRas requested a review from yo1995 June 20, 2023 20:18
@CalebRas CalebRas requested a review from mhdostal June 28, 2023 20:51
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some docs changes. I'll add more feedback on the data model soon.

Co-authored-by: Ting <tchen@esri.com>
@CalebRas CalebRas requested a review from yo1995 June 28, 2023 23:36
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of making separate comments, I decided to stash my suggestions on a branch. Here are the compared branches: https://github.com/Esri/arcgis-maps-sdk-swift-samples/compare/Caleb/New-SetUpLocationDrivenGeotrigers...Ting/GeotriggerSuggestions?expand=1

We can discuss these suggestions in detail. Once we are all good, you can merge it into your branch locally and update the PR. Or if you want me to comment on the changes on GitHub, feel free to open a PR targeting your branch and I can add the comments on their lines.

@CalebRas CalebRas requested a review from yo1995 July 3, 2023 19:54
@yo1995
Copy link
Collaborator

yo1995 commented Jul 6, 2023

Hi @mhdostal if you have a chance can you review this PR? Or assign to someone else using the sample reviewers alias.

Copy link
Member

@mhdostal mhdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, very nice work!

@CalebRas CalebRas merged commit c92e82c into v.next Jul 7, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-SetUpLocationDrivenGeotrigers branch July 7, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants