[New] Display map from portal item #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo1995
reviewed
Jun 16, 2023
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Outdated
Show resolved
Hide resolved
yo1995
reviewed
Jun 20, 2023
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Outdated
Show resolved
Hide resolved
…alItemView.swift Co-authored-by: Ting <tchen@esri.com>
yo1995
reviewed
Jun 21, 2023
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Show resolved
Hide resolved
yo1995
requested review from
a team,
philium and
mhdostal
and removed request for
a team and
philium
|
I have reshuffled the auto-assignment of Phil from this PR review, as he has reviewed a few other PR recently. |
Co-authored-by: Ting <tchen@esri.com>
yo1995
approved these changes
Jun 22, 2023
Shared/Samples/Display map from portal item/DisplayMapFromPortalItemView.swift
Show resolved
Hide resolved
mhdostal
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Display map from portal iteminMapscategory.URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-DisplayMapFromPortalItem/Shared/Samples/Display%20map%20from%20portal%20item
Linked Issue(s)
swift/issues/4183How To Test
Screenshots