Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Create convex hull around geometries #215

Merged
merged 13 commits into from
Jun 29, 2023

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements Create convex hull around geometries in Geometry category.
URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-CreateConvexHullAroundGeometries/Shared/Samples/Create%20convex%20hull%20around%20geometries

Linked Issue(s)

  • swift/issues/4206

How To Test

  • Tap the "Create" button.
  • Tap the "Union" toggle switch.
  • Tap the "Reset" button.

Screenshots

create-convex-hull-around-geometries

@CalebRas CalebRas requested a review from yo1995 June 27, 2023 22:19
@CalebRas CalebRas self-assigned this Jun 27, 2023
@yo1995 yo1995 requested review from a team, njarecha and dfeinzimer and removed request for a team and njarecha June 28, 2023 17:58
@yo1995
Copy link
Collaborator

yo1995 commented Jun 28, 2023

It seems I cannot unassigned myself, so I'll assign Destiny instead. 🤐

@yo1995 yo1995 requested a review from des12437 June 28, 2023 17:59
@CalebRas CalebRas requested a review from des12437 June 28, 2023 19:45
CalebRas and others added 2 commits June 28, 2023 13:44
…exHullAroundGeometriesView.swift

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
@CalebRas CalebRas merged commit aaa64e7 into v.next Jun 29, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-CreateConvexHullAroundGeometries branch June 29, 2023 00:14
@njarecha
Copy link
Contributor

I did not realize this was not assigned to me anymore but have only feedback that the Union switch should be disabled when there are no graphics in the convexHullGraphicsOverlay. Just add .disabled(convexHullGraphicsOverlay.graphics.isEmpty) on Toggle("Union", isOn: $shouldUnion).

@yo1995
Copy link
Collaborator

yo1995 commented Jun 29, 2023

Thanks Nimesh, I'll log an issue to improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants