-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Create convex hull around geometries #215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo1995
reviewed
Jun 28, 2023
Shared/Samples/Create convex hull around geometries/CreateConvexHullAroundGeometriesView.swift
Outdated
Show resolved
Hide resolved
yo1995
reviewed
Jun 28, 2023
yo1995
requested review from
a team,
njarecha and
dfeinzimer
and removed request for
a team and
njarecha
June 28, 2023 17:58
It seems I cannot unassigned myself, so I'll assign Destiny instead. 🤐 |
Co-authored-by: Ting <tchen@esri.com>
des12437
reviewed
Jun 28, 2023
Shared/Samples/Create convex hull around geometries/CreateConvexHullAroundGeometriesView.swift
Outdated
Show resolved
Hide resolved
des12437
reviewed
Jun 28, 2023
Shared/Samples/Create convex hull around geometries/CreateConvexHullAroundGeometriesView.swift
Outdated
Show resolved
Hide resolved
…exHullAroundGeometriesView.swift Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
des12437
approved these changes
Jun 28, 2023
dfeinzimer
approved these changes
Jun 29, 2023
I did not realize this was not assigned to me anymore but have only feedback that the |
Thanks Nimesh, I'll log an issue to improve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Create convex hull around geometries
inGeometry
category.URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-CreateConvexHullAroundGeometries/Shared/Samples/Create%20convex%20hull%20around%20geometries
Linked Issue(s)
swift/issues/4206
How To Test
Screenshots