Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Sample categories - first batch #218

Merged
merged 4 commits into from
Jul 3, 2023

Conversation

CalebRas
Copy link
Contributor

@CalebRas CalebRas commented Jun 29, 2023

Description

This PR updates the "category" in the metadata file to match the [https://github.com/Esri/arcgis-maps-sdk-kotlin-samples](Kotlin samples) and the common design sample categories for the first half of the swift samples.

Linked Issue(s)

  • swift/issues/4227
  • Common Design PR: #3856

How To Test

  • Verify each sample category matches the corresponding Kotlin sample and/or the correct common design sample category.

@CalebRas CalebRas requested a review from yo1995 June 29, 2023 20:48
@CalebRas CalebRas self-assigned this Jun 29, 2023
@yo1995 yo1995 marked this pull request as draft June 30, 2023 00:32
@yo1995 yo1995 marked this pull request as ready for review July 1, 2023 23:26
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes! Please let me know when it is ready for review.

@CalebRas
Copy link
Contributor Author

CalebRas commented Jul 3, 2023

@yo1995 This first batch should be good to review now since the common design PR was merged.

@CalebRas CalebRas requested a review from yo1995 July 3, 2023 17:58
@CalebRas CalebRas changed the title [Update] Sample categories first batch [Update] Sample categories - first batch Jul 3, 2023
…ata.json

Co-authored-by: Ting <tchen@esri.com>
@CalebRas CalebRas requested a review from yo1995 July 3, 2023 22:58
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Since these changes are not related to the API, I'll skip the review by someone else and merge this PR directly.

@yo1995 yo1995 merged commit 4e537e7 into v.next Jul 3, 2023
1 check passed
@yo1995 yo1995 deleted the Caleb/Update-SampleCategories-One branch July 3, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants