Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Center category grid text #230

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements a fix to the Sample Viewer by centering category title text on the category grid tiles. Initially, text was aligned left when there were multiple lines.

How To Test

  • Load the Sample Viewer on iPad and verify the text is centered on the category grid titles.
  • Verify the app works the same otherwise.

Screenshots

Before After
iPad Screen Shot, Before iPad Screen Shot, After

@CalebRas CalebRas requested a review from yo1995 July 27, 2023 16:52
@CalebRas CalebRas self-assigned this Jul 27, 2023
@yo1995 yo1995 changed the base branch from main to v.next July 27, 2023 16:53
@yo1995 yo1995 requested review from a team, njarecha and dfeinzimer and removed request for a team and njarecha July 27, 2023 16:53
@yo1995
Copy link
Collaborator

yo1995 commented Jul 27, 2023

Unassign Nimesh as he is busy with ft work #230 (comment)

Copy link
Contributor

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on all platforms

@CalebRas CalebRas merged commit 7d52920 into v.next Jul 27, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/Fix-CenterCategoryGridText branch July 27, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants