[New] Download vector tiles to local cache #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo1995
reviewed
Jul 20, 2022
| 1. Create an `ExportVectorTilesTask` object, passing in the `PortalItem` for the vector tiled layer. Since vector tiled layers are premium content, you must first authenticate with the Portal. | ||
| 2. Create parameters for the export by using the task's method, `ExportVectorTilesTask.createDefaultExportVectorTilesParameters(areaOfInterest:maxScale:)`, specifying the area of interest and max scale. | ||
| 3. Create an `ExportVectorTileJob` by using the task's method, `ExportVectorTilesTask.exportVectorTiles(parameters:vectorTileCacheURL:itemResourceCacheURL:)`, passing in the parameters and specifying a vector tile cache path and an item resource path. The resource path is required if you want to export the tiles with the style. | ||
| 4. Start the job, then await the job's results. |
There was a problem hiding this comment.
I feel like the sentence can be rephrased, but will leave it to other reviewers.
Shared/Samples/Download vector tiles to local cache/DownloadVectorTilesToLocalCacheView.swift
Outdated
Show resolved
Hide resolved
yo1995
reviewed
Jul 20, 2022
Shared/Samples/Download vector tiles to local cache/DownloadVectorTilesToLocalCacheView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Download vector tiles to local cache/README.metadata.json
Outdated
Show resolved
Hide resolved
yo1995
previously approved these changes
Aug 4, 2022
yo1995
previously approved these changes
Aug 8, 2022
yo1995
previously approved these changes
Aug 8, 2022
dfeinzimer
reviewed
Aug 10, 2022
dfeinzimer
requested changes
Aug 10, 2022
Shared/Samples/Download vector tiles to local cache/DownloadVectorTilesToLocalCacheView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Download vector tiles to local cache/DownloadVectorTilesToLocalCacheView.swift
Show resolved
Hide resolved
dfeinzimer
requested changes
Aug 10, 2022
Co-authored-by: David Feinzimer <dfeinzimer@gmail.com>
yo1995
previously approved these changes
Aug 11, 2022
clee088
commented
Aug 11, 2022
Shared/Samples/Download vector tiles to local cache/DownloadVectorTilesToLocalCacheView.swift
Outdated
Show resolved
Hide resolved
yo1995
approved these changes
Aug 12, 2022
dfeinzimer
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Download vector tiles to local cacheinLayerscategory.URL to README: URL
Linked Issue(s)
common-samples/issues/3587How To Test
To Discuss
EDIT: No longer an issue. Sample crashes when rotating device in the results sheet
Looks like it traces back to the map's basemap.Results sheet viewpoint
When the results sheet is presented, the viewpoint doesn't seem to be set to the extent or I am unable to make it show the center of the exported tiles.
Area of interest set by geometryI'm not sure if this is the best way to set the area of interest/extent. The iOS samples app just has a fixed UIView and then converts the view to an envelope.