[Fix] accessory button and help text color is not clearly visible #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saratchandrakarumuri
previously approved these changes
Aug 16, 2023
yo1995
reviewed
Aug 17, 2023
yo1995
approved these changes
Aug 17, 2023
saratchandrakarumuri
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in iOS 16+ where the help text and accessory button are not clearly visible when the list item selection color is the accent color (purple/pink) instead of grey. This PR adds opacity to the help text so that the system sets the text color. The accessory button is now a label with an icon and tap gesture rather than a Button since the system will set the color automatically.
Linked Issue(s)
swift/issues/3878How To Test
Screenshots
Before:
After:
