[Update] Download preplanned map area feedback

[des12437]

Description

This PR addresses feedback from Nick on the initial testing for 200.1.0 sample viewer TestFlight app for the Download preplanned map area sample:

• Oooh. A legit bug! I dismissed the preplanned area picker in the preplanned sample then navigated back from the preplanned sample to the samples list and the preplanned area picker reappeared over the sample list! I think you have to download a preplanned area to see this.
  Might be related to the sheet issue as well: Fix sample info view presentation auto dismiss when custom sheet modifier is in place #80

  This PR fixes this bug caused by a sheet selection bug. Previously when the "Done" button was selected the dismiss action did not set the isSelected property to false.

• This map ("Seager Park Area") looks empty by default on an iPhone. I have to zoom in to notice it has content. Not sure what to do about that though…
  I spotted the same when I review this sample. The best way IMO is to set the initial zoom scale on these preplanned map area to a close enough value so the symbols appear on all platform regardless desktop or mobile.

  This issue is fixed by expanding the visible area's envelope when an offline map is selected. Now all layer content is visible for each offline map.

• Would it be better if, when you download an area, it is automatically selected? Currently you have to tap to download, wait for it to download, and then tap it again to select it.

  I did not implement this suggestion based on discussion in the swift issue deciding to not make this change.

Linked Issue(s)

• swift/issues/3931

How To Test

• View each offline map after downloading and verify that all layer content is visible.

Screenshots

Before/After layer visibility

[nixta]

If I open the on-demand sample then the preplanned sample, I don't see any controls below the map.

Oddly, switching between samples got the controls to show up once, but now I can't get them to show up at all.

[des12437]

If I open the on-demand sample then the preplanned sample, I don't see any controls below the map.

Oddly, switching between samples got the controls to show up once, but now I can't get them to show up at all.

I tried to reproduce this on iOS 16 and 17 but could not. What iOS version and simulator did you see this issue on? Also which on-demand sample did you open first?

[nixta]

It's really inconsistent. I got unlucky and saw it first time I ran the app, but after that it took quite some effort to see it again. Just search for "Offline" then switch between Generate and Preplanned. Here's a video. I switched back and forth a lot before I could repro for the video, and you'll notice that I can just exit the sample and go right back in and it works fine again.

iOS 16.6 on an iPhone 14 Pro device.

RPReplay_Final1694185607.mov

Sorry I can't get a better repro!

[nixta]

Aside from the weirdness of the bottom UX not appearing on the odd occasion, this looks much better. Thank you!

I'll let someone else make the call about whether that should be a show-stopper. Given how hard it's been for me to repro, I'd say probably not. We could open another issue for that.

[des12437]

Aside from the weirdness of the bottom UX not appearing on the odd occasion, this looks much better. Thank you!

I'll let someone else make the call about whether that should be a show-stopper. Given how hard it's been for me to repro, I'd say probably not. We could open another issue for that.

I will log a separate issue for the UI bug, thank you for finding that!